Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add daft launcher docs to docs v2 #3678

Merged
merged 21 commits into from
Jan 16, 2025
Merged

docs: add daft launcher docs to docs v2 #3678

merged 21 commits into from
Jan 16, 2025

Conversation

ccmao1130
Copy link
Contributor

Docs Issue: #3621

Added Daft Launcher MD Book to docs v2

@github-actions github-actions bot added the docs label Jan 13, 2025
Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #3678 will not alter performance

Comparing daft-docs-v2 (1444959) with main (6157ad8)

Summary

✅ 27 untouched benchmarks

@ccmao1130
Copy link
Contributor Author

@raunakab Can you review the commands and make sure that all the flags/commands/args are correct? (and nit-picky things like single dash or double dash)

Also would like to point out that there's a slight mismatch for daft submit between the daft-launcher readme:
image
and daft-launcher md book:
image
so just want to make sure what the proper syntax is here.

Thanks!

@ccmao1130 ccmao1130 mentioned this pull request Jan 13, 2025
15 tasks
@ccmao1130 ccmao1130 marked this pull request as ready for review January 13, 2025 22:53
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.84%. Comparing base (c932ec9) to head (1444959).
Report is 11 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3678      +/-   ##
==========================================
- Coverage   78.06%   76.84%   -1.23%     
==========================================
  Files         728      727       -1     
  Lines       89967    92741    +2774     
==========================================
+ Hits        70236    71263    +1027     
- Misses      19731    21478    +1747     

see 53 files with indirect coverage changes

@raunakab
Copy link
Contributor

raunakab commented Jan 15, 2025

@raunakab Can you review the commands and make sure that all the flags/commands/args are correct? (and nit-picky things like single dash or double dash)

Also would like to point out that there's a slight mismatch for daft submit between the daft-launcher readme: image and daft-launcher md book: image so just want to make sure what the proper syntax is here.

Thanks!

@ccmao1130 Looks good so far. There will be a couple of changes landing to Daft Launcher in the near future (maybe in a week after proper testing and alpha releasing), but for now, this looks correct.

Before merging it in, let me ensure that this is correct by running some commands. I'll get back to you asap.

Copy link
Contributor

@colin-ho colin-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccmao1130 ccmao1130 merged commit f97902a into main Jan 16, 2025
42 of 43 checks passed
@ccmao1130 ccmao1130 deleted the daft-docs-v2 branch January 16, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants