-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add daft launcher docs to docs v2 #3678
Conversation
CodSpeed Performance ReportMerging #3678 will not alter performanceComparing Summary
|
@raunakab Can you review the commands and make sure that all the flags/commands/args are correct? (and nit-picky things like single dash or double dash) Also would like to point out that there's a slight mismatch for Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3678 +/- ##
==========================================
- Coverage 78.06% 76.84% -1.23%
==========================================
Files 728 727 -1
Lines 89967 92741 +2774
==========================================
+ Hits 70236 71263 +1027
- Misses 19731 21478 +1747 |
@ccmao1130 Looks good so far. There will be a couple of changes landing to Daft Launcher in the near future (maybe in a week after proper testing and alpha releasing), but for now, this looks correct. Before merging it in, let me ensure that this is correct by running some commands. I'll get back to you asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Docs Issue: #3621
Added Daft Launcher MD Book to docs v2