Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run filter null join key optimization once #3657

Merged
merged 1 commit into from
Jan 9, 2025

run filter null join key once

f94058b
Select commit
Loading
Failed to load commit list.
Merged

fix: Run filter null join key optimization once #3657

run filter null join key once
f94058b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

78.08% (+0.04%) compared to 426ddd0

View this Pull Request on Codecov

78.08% (+0.04%) compared to 426ddd0

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (426ddd0) to head (f94058b).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
+ Coverage   78.04%   78.08%   +0.04%     
==========================================
  Files         727      728       +1     
  Lines       89762    90092     +330     
==========================================
+ Hits        70052    70352     +300     
- Misses      19710    19740      +30     
Files with missing lines Coverage Δ
...rc/daft-logical-plan/src/optimization/optimizer.rs 94.97% <100.00%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes