Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Classify throttle and internal errors as Retryable in Python #2914

Merged
merged 7 commits into from
Sep 25, 2024

fix self lints

8560ec6
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Classify throttle and internal errors as Retryable in Python #2914

fix self lints
8560ec6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 25, 2024 in 0s

75.33% (-3.02%) compared to d57433a

View this Pull Request on Codecov

75.33% (-3.02%) compared to d57433a

Details

Codecov Report

Attention: Patch coverage is 20.51282% with 31 lines in your changes missing coverage. Please review.

Project coverage is 75.33%. Comparing base (d57433a) to head (8560ec6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-io/src/s3_like.rs 13.79% 25 Missing ⚠️
src/daft-io/src/lib.rs 0.00% 4 Missing ⚠️
src/common/error/src/python.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   78.34%   75.33%   -3.02%     
==========================================
  Files         596      596              
  Lines       69875    70952    +1077     
==========================================
- Hits        54747    53454    -1293     
- Misses      15128    17498    +2370     
Files with missing lines Coverage Δ
daft/exceptions.py 100.00% <100.00%> (ø)
src/common/error/src/error.rs 100.00% <ø> (ø)
src/common/error/src/python.rs 57.14% <0.00%> (-9.53%) ⬇️
src/daft-io/src/lib.rs 75.91% <0.00%> (-1.50%) ⬇️
src/daft-io/src/s3_like.rs 64.20% <13.79%> (-5.73%) ⬇️

... and 28 files with indirect coverage changes