[FEAT]: [SQL] struct subscript and json_query #2891
Conversation
CodSpeed Performance ReportMerging #2891 will not alter performanceComparing Summary
|
…-and-subscript-sql
| // TODO | ||
| fn register(parent: &mut SQLFunctions) { | ||
| parent.add_fn("map_get", MapGet); | ||
| parent.add_fn("map_extract", MapGet); |
There was a problem hiding this comment.
Is this an alias to maintain ANSI/postgres compatibility?
There was a problem hiding this comment.
AFAIK, ANSI doesn't really have any standard for what you can/cant call your functions. I mostly added the alias because I've seen it in other db systems (such as duckdb).
| Ok(daft_functions::list::slice(expr, lower, upper)) | ||
| } | ||
| _ => { | ||
| unsupported_sql_err!("slice with only one bound not yet supported"); |
There was a problem hiding this comment.
I believe we do currently support it. If lower is not specified, it should be 0. If upper is not specified, we can pass in a null literal to daft_functions::list::slice and it will work properly
There was a problem hiding this comment.
yeah, just havent gotten around to implementing it yet. will follow up with support for it.
Co-authored-by: Jay Chia <17691182+jaychia@users.noreply.github.com>
adds nested access for structs and maps, as well as
json_queryfunction