Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add ability for RayRunner to run actor pool projects (beta feature) #2881

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Sep 21, 2024

Added tests from 675b0b1

@github-actions github-actions bot added the enhancement New feature or request label Sep 21, 2024
Copy link

codspeed-hq bot commented Sep 21, 2024

CodSpeed Performance Report

Merging #2881 will not alter performance

Comparing jay/ray-apps (f761629) with main (05eeffb)

Summary

✅ 17 untouched benchmarks

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 45.33333% with 41 lines in your changes missing coverage. Please review.

Project coverage is 66.49%. Comparing base (b0f31e3) to head (f761629).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
daft/runners/ray_runner.py 47.22% 38 Missing ⚠️
daft/execution/physical_plan.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   65.26%   66.49%   +1.23%     
==========================================
  Files         999     1005       +6     
  Lines      117521   114357    -3164     
==========================================
- Hits        76695    76037     -658     
+ Misses      40826    38320    -2506     
Flag Coverage Δ
66.49% <45.33%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
daft/udf.py 94.50% <ø> (ø)
daft/execution/physical_plan.py 89.02% <0.00%> (-0.28%) ⬇️
daft/runners/ray_runner.py 75.71% <47.22%> (-3.44%) ⬇️

... and 154 files with indirect coverage changes

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look at it, need to take some more time to dive into the details but should not introduce any regressions on existing behavior, so approving merge under the actor pool feature flag

@kevinzwang kevinzwang merged commit 195dd00 into main Sep 25, 2024
41 of 42 checks passed
@kevinzwang kevinzwang deleted the jay/ray-apps branch September 25, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants