Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Add native executor to CI #2855

Merged
merged 7 commits into from
Sep 19, 2024
Merged

[CHORE] Add native executor to CI #2855

merged 7 commits into from
Sep 19, 2024

Conversation

colin-ho
Copy link
Contributor

@colin-ho colin-ho commented Sep 18, 2024

Enables native executor in CI (just unit tests for now). Any tests that fail because the native executor doesn't support it yet is marked as skip. The skips will be incrementally removed as functionality gets added.

@colin-ho colin-ho marked this pull request as ready for review September 18, 2024 17:51
@github-actions github-actions bot added the chore label Sep 18, 2024
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #2855 will improve performances by ×2.3

Comparing colin/native_executor_ci (d824109) with main (6766955)

Summary

⚡ 1 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main colin/native_executor_ci Change
test_count[1 Small File] 23.7 ms 10.2 ms ×2.3

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.40%. Comparing base (6766955) to head (d824109).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2855      +/-   ##
==========================================
+ Coverage   64.10%   65.40%   +1.29%     
==========================================
  Files        1005     1005              
  Lines      113099   113099              
==========================================
+ Hits        72505    73972    +1467     
+ Misses      40594    39127    -1467     

see 38 files with indirect coverage changes

Copy link
Contributor

@desmondcheongzx desmondcheongzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@colin-ho colin-ho merged commit 7666669 into main Sep 19, 2024
44 checks passed
@colin-ho colin-ho deleted the colin/native_executor_ci branch September 19, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants