EventSource still reconnected when closed

[FrozenCow]

Following the specs a connection can be closed during reconnection-timeout: http://dev.w3.org/html5/eventsource/#reestablish-the-connection

EventSource did not do this at the moment, so it wasn't possible to 'cancel' a reconnect when a remote connection was closed.

[aslakhellesoy]

Thanks. Could you please add a test that fails without your change and passes with it?

[FrozenCow]

Alright the test is added. It fails here for master and passes for patch-1. I've used a timeout of 100ms, but that might be too much... I just used a high value to be sure it's ran correctly.

[aslakhellesoy]

Thanks - I have merged this.

Unrelated to your fix - after I merged your patch I had some failing tests locally because last I ran them I was on an older version of Node, but now I'm on Node 0.10.18. I made some changes until all my tests were passing locally again.

I changed the Travis config to build on 0.10.18 as well, but unfortunately Travis doesn't agree with my local machine and fails 5 tests: https://travis-ci.org/aslakhellesoy/eventsource-node

Long story short - I don't want to release until Travis is green.

Are all tests passing for you on 0.10.18 or do you see what Travis see? It would be help to get some help to reproduce (and fix) this.

[FrozenCow]

I'm also running node v0.10.18 and for me the tests run without problems. v0.10.17 also worked fine, however I have not tried v0.10.12, which Travis seems to be running on.

I have reproduced the errors when using 0.10.12 by doing:

$ npm install -g n
$ n 0.10.12
$ PATH=$(n bin 0.10.12):$PATH bash
$ cd ~/projects/eventsource-node
$ npm test

It seems this issue was fixed in node between 0.10.12 and 0.10.17. Maybe you should just let Travis build for a older of node (v0.8.25)? I'm not sure how to fix the issue.

[aslakhellesoy]

Thanks - I fixed it here: bbaeb2f

I'm watching nodejs/node-v0.x-archive#5439 - when it's fixed we should be able to let Travis run more recent versions of Node.

[FrozenCow]

Sounds good. That issue is talking about v0.10.5, so I guess there is a range of versions of node affected (v0.10.5 till at least v0.10.12). I don't mind waiting a for Travis to upgrade before a new release of EventSource.

[aslakhellesoy]

I already released!

[FrozenCow]

Oh awesome, thanks!