Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/1113 #1145

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Feat/1113 #1145

merged 8 commits into from
Dec 5, 2024

Conversation

bebopkenny
Copy link
Collaborator

Worked on #1113 to add the directors name and picture.
Screenshot 2024-10-29 164706

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit e242ee6
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/67510e2e74ca850008563104
😎 Deploy Preview https://deploy-preview-1145--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@26samaahmed 26samaahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When passing the director.picture for src to display the directors' pictures, you can surround it by 1 curly bracket only. We have the value for pictures set as the file path already so there's no need for extra formatting. It would look like this:

Screenshot 2024-10-29 201905

Copy link
Collaborator

@26samaahmed 26samaahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see the the outer div being used so we can remove it. Make sure to run 'npm run all' before you push to make sure your code is formatted 🫡

@26samaahmed
Copy link
Collaborator

It looks really good, I added a bit more styling to the pictures! Congrats @bebopkenny on resolving your first issue 😎

Screenshot 2024-12-04 181641

Copy link
Collaborator

@26samaahmed 26samaahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@26samaahmed 26samaahmed merged commit 81cebae into main Dec 5, 2024
5 checks passed
@26samaahmed 26samaahmed deleted the feat/1113 branch February 18, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants