Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the /about page #1048

Merged
merged 2 commits into from
Mar 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ In that directory, each file with a prefix <kbd>+</kbd> represents an endpoint o
| Path of File | Production URL |
| -------------------------------- | ---------------------------- |
| `/src/routes/+page.svelte` | `https://acmcsuf.com/` |
| `/src/routes/about/+page.svelte` | `https://acmcsuf.com/about/` |
| `/src/routes/teams/+page.svelte` | `https://acmcsuf.com/teams/` |
| `/src/routes/paths/+page.svelte` | `https://acmcsuf.com/paths/` |

> ℹ more info: <https://kit.svelte.dev/docs/routing#advanced-routing>
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ ARCHIVE_CHANNEL_ID=YOUR_ARCHIVE_CHANNEL_ID

## Updating board member data

To update the way an officer appears on <https://acmcsuf.com/about>, contributors may directly edit our `src/lib/public/board/data/officers.json` JSON file.
To update the way an officer appears on <https://acmcsuf.com/teams>, contributors may directly edit our `src/lib/public/board/data/officers.json` JSON file.

Alternatively board members may update their own board member data using a Discord slash command `/boardd` in our official club Discord server. For more information, see <https://acmcsuf.com/boardify>.

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Maintained with 💖 by [**acmcsuf.com hub**][team_doc]
[node_download]: https://nodejs.org/en/download/
[github_action_deploy]: .github/workflows/deploy.yaml
[demo_url]: https://acmcsuf.com/
[acm_officers]: https://acmcsuf.com/about/
[acm_officers]: https://acmcsuf.com/teams/
[webmaster_url]: https://github.com/EthanThatOneKid/
[dev_server]: http://localhost:3000/
[netlify_dashboard]: https://app.netlify.com/sites/acmcsuf
Expand Down
1 change: 0 additions & 1 deletion src/lib/components/nav/bar.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
onMount(() => (jsEnabled = true));

const navItems = [
{ title: 'About', path: '/about' },
{ title: 'Events', path: '/events' },
{ title: 'Teams', path: '/teams' },
{ title: 'Blog', path: '/blog' },
Expand Down
37 changes: 0 additions & 37 deletions src/routes/(site)/about/+page.svelte

This file was deleted.

65 changes: 0 additions & 65 deletions src/routes/(site)/about/about-us.svelte

This file was deleted.

2 changes: 1 addition & 1 deletion src/routes/(site)/nodebuds/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import type { Officer } from '$lib/public/board/types';
import { VISIBLE_TERMS } from '$lib/public/board/data';
import { termIndex } from '$lib/public/board/utils';
import OfficerProfileList from '../about/officer-profile-list.svelte';
import OfficerProfileList from '../teams/officer-profile-list.svelte';
function filterNodeBuddies(officer: Officer): boolean {
const positions = officer.positions[VISIBLE_TERMS[$termIndex]];
Expand Down
2 changes: 1 addition & 1 deletion src/routes/(site)/teams/members.svelte
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">
import type { Officer, Term, Team } from '$lib/public/board';
import OfficerProfile from '../about/officer-profile.svelte';
import OfficerProfile from './officer-profile.svelte';
export let data: { members: Officer[]; term: Term; team: Team };
</script>
Expand Down
13 changes: 0 additions & 13 deletions static/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,6 @@
"type": "image/png"
}
]
},
{
"name": "About acmCSUF",
"short_name": "About",
"description": "Read all about acmCSUF!",
"url": "/about",
"icons": [
{
"src": "/android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png"
}
]
}
],
"display": "standalone",
Expand Down
Loading