Make moveItem's folder parameter optional #306
Conversation
| @@ -27,7 +27,7 @@ export interface IItemMoveRequestOptions extends IItemCrudRequestOptions { | |||
| * Alphanumeric id of folder to house moved item. If null, empty, or "/", the destination is the | |||
| * root folder. | |||
| */ | |||
| folder: string; | |||
| folder?: string; | |||
There was a problem hiding this comment.
my preference would be to use folderId consistently instead of folder.
see #236
There was a problem hiding this comment.
@jgravois, I agree, but then it would be different than the corresponding parameter in the REST call (https://developers.arcgis.com/rest/users-groups-and-items/move-item.htm); is that OK?
There was a problem hiding this comment.
yes. I think the REST parameter name is a footgun.
There was a problem hiding this comment.
yeah, we're even less clear about our guidelines (or lack thereof) on trying to stick to the shape (names, etc) of the REST API, except in those cases where it doesn't make sense. Some ambiguous balance of replicating an API that people are already familiar with and building the API we would want to use.
No description provided.