Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append eval and eval_point to transcript #174

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: append eval and eval_point to transcript #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66c0070
append eval and eval_point before batch_open
alxiong Feb 20, 2025
e58574f
move logic to PCS.batch_open/verify instead
alxiong Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hyperplonk/src/snark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,8 +603,8 @@ where
points.push(r_pi_padded);
assert_eq!(comms.len(), proof.batch_openings.f_i_eval_at_point_i.len());
end_timer!(pi_step);

end_timer!(step);

let step = start_timer!(|| "PCS batch verify");
// check proof
let res = PCS::batch_verify(
Expand Down
12 changes: 12 additions & 0 deletions subroutines/src/pcs/multilinear_kzg/batching.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ where
>,
{
let open_timer = start_timer!(|| format!("multi open {} points", points.len()));
for eval_point in points.iter() {
transcript.append_serializable_element(b"eval_point", eval_point)?;
}
for eval in evals.iter() {
transcript.append_field_element(b"eval", eval)?;
}

// TODO: sanity checks
let num_var = polynomials[0].num_vars;
Expand Down Expand Up @@ -198,6 +204,12 @@ where
>,
{
let open_timer = start_timer!(|| "batch verification");
for eval_point in points.iter() {
transcript.append_serializable_element(b"eval_point", eval_point)?;
}
for eval in proof.f_i_eval_at_point_i.iter() {
transcript.append_field_element(b"eval", eval)?;
}

// TODO: sanity checks

Expand Down