-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): support interrupting stream, support slash commands #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 5b90039 in 1 minute and 18 seconds
More details
- Looked at
109
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. gptme/server/api.py:199
- Draft comment:
Theinterrupted
flag is set but not used effectively. Ensure that the logic for handling interruptions is complete and correct. - Reason this comment was not posted:
Comment did not seem useful.
2. gptme/server/api.py:184
- Draft comment:
Theclient_disconnected
function is not implemented. Consider implementing it to handle client disconnections properly. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_rog8bSb8G90vtOsP
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #248 +/- ##
==========================================
- Coverage 72.36% 72.09% -0.27%
==========================================
Files 60 60
Lines 3893 3906 +13
==========================================
- Hits 2817 2816 -1
- Misses 1076 1090 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a12ace2 in 16 seconds
More details
- Looked at
82
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. gptme/server/api.py:9
- Draft comment:
Theclient_disconnected
function is defined but not used, and the logic for checking client disconnection is commented out. Consider removing the function or implementing the logic to avoid confusion. - Reason this comment was not posted:
Confidence changes required:50%
Theclient_disconnected
function is defined but not used, and the logic for checking client disconnection is commented out. This could lead to confusion or missed functionality.
2. gptme/server/api.py:146
- Draft comment:
Consider moving the initialization ofoutput
closer to its first use to improve readability. - Reason this comment was not posted:
Confidence changes required:20%
Theoutput
variable is initialized as an empty string at the start of thegenerate
function, but it is not used until later. This initialization could be moved closer to its first use to improve code readability.
3. gptme/server/api.py:144
- Draft comment:
Theclient_disconnected
function is defined but not used, and the logic for checking client disconnection is commented out. Consider removing the function or implementing the logic to avoid confusion. - Reason this comment was not posted:
Confidence changes required:50%
Theclient_disconnected
function is defined but not used, and the logic for checking client disconnection is commented out. This could lead to confusion or missed functionality.
Workflow ID: wflow_98SiU98ZWcMJCw9c
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…lash commands
Important
Refactor
api_conversation_generate()
to handle user commands during streaming and manage client disconnections ingptme/server/api.py
.api_conversation_generate()
to execute user commands during streaming.generate()
, marking output as interrupted.api_conversation_generate()
.client_disconnected()
placeholder ingenerate()
.generate()
to reflect client disconnection and completion.This description was created by
for a12ace2. It will automatically update as commits are pushed.