Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaspersky av logs #218

Merged
merged 7 commits into from
Jun 9, 2023
Merged

Conversation

randomaccess3
Copy link
Contributor

Description

Please include a summary of the change and (if applicable) which issue is fixed.

Checklist:

Please replace every instance of [ ] with [X] OR click on the checkboxes after you submit your PR

  • I have ensured a Provider is listed for the new Map(s) being submitted
  • I have ensured the filename(s) of any new Map(s) being submitted follows the approved format, i.e. Channel-Name_Provider-Name_EventID.map. In summary, all spaces and special characters are replaced with a hyphen with an underscore separates Channel Name, Provider Name, and Event ID
  • I have tested and validated the new Map(s) work with my test data and achieve the desired output
  • I have provided example event data (# Example Event Data:) at the bottom of my Map(s), if possible
  • I have consulted the Guide/Template to ensure my Map(s) follow the same format

Thank you for your submission and for contributing to the DFIR community!

@randomaccess3
Copy link
Contributor Author

No idea whats going on here
There's a new line character at the end
and there's no trailing spaces

It runs fine with evtxecmd

@AndrewRathbun
Copy link
Collaborator

No idea whats going on here
There's a new line character at the end
and there's no trailing spaces

It runs fine with evtxecmd

I'll take a peek here in a bit. It'll run fine in evtxecmd but it's just a linting rule that's triggering to hit on the petty stuff. I'll be able to triage when I get to the keyboard for the day. Thanks for the PR!

@AndrewRathbun AndrewRathbun self-assigned this Apr 27, 2023
@AndrewRathbun
Copy link
Collaborator

@randomaccess3 I think it was looking for the # Documentation line at the end, and then the newline. I added both and now we have a green checkmark.

@AndrewRathbun
Copy link
Collaborator

Also, do you have example event log data you can populate in the comments? Can always be added later, if possible.

Example:

Copy link
Collaborator

@AndrewRathbun AndrewRathbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay on this @randomaccess3

@AndrewRathbun AndrewRathbun merged commit 87903c8 into EricZimmerman:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants