Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Operational Degradation #198

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

RandyRandleman
Copy link
Contributor

@RandyRandleman RandyRandleman commented Jun 23, 2022

Description

Please include a summary of the change and (if applicable) which issue is fixed.

Checklist:

Please replace every instance of [ ] with [X] OR click on the checkboxes after you submit your PR

  • I have ensured a Provider is listed for the new Map(s) being submitted
  • I have ensured the filename(s) of any new Map(s) being submitted follows the approved format, i.e. Channel-Name_Provider-Name_EventID.map. In summary, all spaces and special characters are replaced with a hyphen with an underscore separates Channel Name, Provider Name, and Event ID
  • I have tested and validated the new Map(s) work with my test data and achieve the desired output
  • I have provided example event data (# Example Event Data:) at the bottom of my Map(s), if possible
  • I have consulted the Guide/Template to ensure my Map(s) follow the same format

Thank you for your submission and for contributing to the DFIR community!

@RandyRandleman
Copy link
Contributor Author

error doesn't appear to be mine?

Copy link
Collaborator

@AndrewRathbun AndrewRathbun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an issue with the wrong encoding. It seems to have converted when I corrected a couple minor issues I saw in the comments. All set now!

@AndrewRathbun AndrewRathbun merged commit e4e55b4 into EricZimmerman:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants