Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #974

Merged
merged 5 commits into from
Dec 7, 2024
Merged

Conversation

cdoko
Copy link
Collaborator

@cdoko cdoko commented Dec 6, 2024

Currently, when the bos_token_id or eos_token_id field is missing from generation_config.json, the error message is "Error(missing field bos_token_id`", line: 4, column: 1)", which does not provide clear context about the source of the issue.

This change indicates the problem is in the generation_config.json file.

Copy link

github-actions bot commented Dec 6, 2024

Code Metrics Report
  ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 C Header                2           35           28            0            7
 Dockerfile              1           41           22           10            9
 JSON                   12          105          104            0            1
 Python                 63         2706         2339           70          297
 Shell                   1           57           22           18           17
 Plain Text              3         3723            0         2413         1310
 TOML                   18          598          532            2           64
 YAML                    2           21           19            2            0
-------------------------------------------------------------------------------
 Jupyter Notebooks       4            0            0            0            0
 |- Markdown             2           77           32           31           14
 |- Python               2          205          178            1           26
 (Total)                            282          210           32           40
-------------------------------------------------------------------------------
 Markdown               43         3324            0         2520          804
 |- BASH                 6          101           98            0            3
 |- JSON                 1           12           12            0            0
 |- Python               7          121          109            0           12
 |- Rust                12          406          344            0           62
 |- TOML                 2           75           63            0           12
 (Total)                           4039          626         2520          893
-------------------------------------------------------------------------------
 Rust                  286        87287        78390         1804         7093
 |- Markdown           138         1483           25         1350          108
 (Total)                          88770        78415         3154         7201
===============================================================================
 Total                 435        97897        81456         6839         9602
===============================================================================
  

Copy link
Owner

@EricLBuehler EricLBuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you please also add this logic to the vision pipeline (i.e. vision.rs)?

Copy link
Collaborator Author

@cdoko cdoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the logic to the vision pipeline as requested, and additionally to the ggml and gguf pipelines.

Copy link
Owner

@EricLBuehler EricLBuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@EricLBuehler EricLBuehler merged commit 20b8204 into EricLBuehler:master Dec 7, 2024
2 checks passed
@cdoko cdoko deleted the error-handling branch December 8, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants