-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release using cargo-dist #480
Conversation
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Code Metrics Report=============================================================================== Language Files Lines Code Comments Blanks =============================================================================== Dockerfile 1 34 25 0 9 Happy 1 442 369 0 73 JSON 9 21 21 0 0 Python 32 1256 1075 37 144 TOML 16 444 403 1 40 ------------------------------------------------------------------------------- Jupyter Notebooks 1 0 0 0 0 |- Markdown 1 60 30 22 8 |- Python 1 96 87 1 8 (Total) 156 117 23 16 ------------------------------------------------------------------------------- Markdown 18 1321 0 982 339 |- BASH 5 100 97 0 3 |- Python 6 122 110 0 12 |- Rust 3 151 135 6 10 (Total) 1694 342 988 364 ------------------------------------------------------------------------------- Rust 119 36409 32892 648 2869 |- Markdown 59 663 13 613 37 (Total) 37072 32905 1261 2906 =============================================================================== Total 198 39927 34785 1668 3474 =============================================================================== |
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Hi @kranurag7! Thanks for adding this. I noticed you added a few new CI steps: build-global-artifacts, host, announce. I was wondering if you could give a quick overview of what you added and generally how it works? In particular, we already use GH releases to create tags and track releases, so I'm not sure if that would be affected by the new
Sounds good. |
The build jobs builds the artifacts and then we create a release in GitHub. This means you'll get your release assets uploaded and a table which will ease the downloading of tarballs for users. See https://github.com/kranurag7/mistral.rs/releases/tag/v0.1.24 This is what is done in the last From what I see, you push a tag to build the image via two workflow. This workflow extends that, now when you push the tag, you'll have your binaries present as well on the releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
so glad to see this! sorry i dropped the ball on actually making the PR. in case it's not clear, the tool |
# CI backends to support | ||
ci = "github" | ||
# The installers to generate for each app | ||
installers = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for ease of installing, you may want to add some installers :) this will let people install the pre-built binaries instead of having to compile on their machine with cargo install
Fixes: #263
As of now, musl and windows based build are disabled because they were breaking, I can take a look at fixing those later.
I created a release on my fork here: https://github.com/kranurag7/mistral.rs/releases/tag/v0.1.24