Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions workflow for master branch #101

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

who-biz
Copy link
Contributor

@who-biz who-biz commented Aug 17, 2023

Changes included in this PR add continuous integration for epic repository, to verify functional compilation.

It will do so for any push to master branch, or any PR made to master branch. A badge has also been added to the repository's README for indication of current repo status (i.e. Passing, Failed).

It specifies use of a specific rust toolchain (1.67.1 presently) as well.

Two changes were made in 1c4fc7b for removal of mut keywords that were unused. These were causing compilation failures.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- Switch badge from readme to proper URL for Epic repo
@who-biz who-biz merged commit 3c6b12e into EpicCash:master Aug 18, 2023
@who-biz who-biz deleted the github-actions branch August 18, 2023 16:48
@johanneshahn
Copy link
Member

what is the latest nightly rust version you can compile with?

and does stable works?

@who-biz

@who-biz
Copy link
Contributor Author

who-biz commented Aug 21, 2023

what is the latest nightly rust version you can compile with?

and does stable works?

@who-biz

Not sure. Haven’t tested anything above 1.67.1 which is same as stable. It is versioned explicitly to avoid compilation failures in event of upstream stable version change.

@skykingisepic
Copy link

I have been using 1.62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants