Time to merge Paleoterra redox into develop? #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Paleo Terra Redox sensors, reading out only a voltage in uV. Code compiles and runs but has not been tested with Paleo Terra hardware in the loop Also need to add failure conditions in order to return -9999 for the correct conditions of operation, some hardware testing will be required
NOTE: To verify the presance of absance of the sensor, it the code checks the result of the conversion, the i2c status bit, and the value of the config register. If the conversion result is 0, the i2c status 0, and the config is invalid, this corresponds to a detached sensor and the result will return -9999. This solution has the following known errata, if the sensor reads a value of 0 while operating in 12 bit mode (so config = 0x00) then it will return an erronious -9999, this is extremely unlikely (and we are currently operating in 18 bit mode) but should be documented.
Hopefully fixes #142
Also longer waiting time for interenet connect for first clock sync
Can either hold up and wait for a button press at a certain time, or set up an interrupt for it.
I had missed for AnthonyTest2.ino previously. I'll probably delete this file before merging to Master.
Demos of how to create the variable pointers inside or outside of the variable array
Setup does not need to be overridden
Pulling master in to PaleoTerraRedox to use current modular formats
Major switch to using Testato's SoftwareWire instead of TodBot's, as described by @SRGDamia1 in #264 (comment)
|
@SRGDamia1 describes some important points describing the change to Testato's SoftwareWire (I2C) instead of TodBot's, and some general points regarding SoftwareWire in #264 (comment). I point out the latest tests by @fisherba of this in #264 (comment), which were only using hardware I2C for redox sensors and also not using the code at the head of this branch. I think that it might be wise to test this further before merging into develop. |
|
@aufdenkampe I am working on this merge right now! Please do not make any changes on this branch until I have pushed my work. (It's a messy merge so it will take me some time to clean it.) |
|
@SRGDamia1, sounds good. I'll leave this Paleoterra redox branch all to you! |
This was *supposed* to be just a merge, but in fixing the conflicts I got carried away and added all the documentation and a bunch of other things that should have been separate commits. I'm not untangling it all now.
|
Done |
|
@SRGDamia1, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to get this merged so that we don't need to manage it as a separate branch.