-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #173
Conversation
The internal _logModem must be a POINTER not a reference because it is possible for no modem to be attached (and thus the pointer could be null). It is not possible to have a null reference.
OnOff class no longer has subclasses, but instead multiple switch statements.
Current issue: The internet connected loggers want to have an attached modem, and thus the modem.h is read in and pre-compiled with the .h files for those loggers. But the logger modem itself isn't fully defined until compile time (pre-processor macros decided based on particular modem) so the final version of the logger modem instance is different from that of the pre-compiled instance. Ugh.
using modem pointer
Adding KellerNanolevel support - requires KellerModbus lib update
Given develop is nearly 200 commits ahead of master, and as far as I know nearly everyone is using develop anyway. I'm going to merge this and cut a release as soon as the Keller library is updated in the registry and Travis passes. If you have any strong objections, let me know. |
Fantastic. This is a major work Sara, thankyou. Can't wait to try it :). I may not be able to get to it for a couple of days due to other commitments. |
@SRGDamia1, thanks for all your work on this! It is really impressive! |
The new release on master works for me, as a merge into my work branch. |
So many changes to this Major Update (for version 0.17.2)!