Kill init #155
Merged
Kill init #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why I thought this could not be done.
but instead contains a variable array object as an internal member Also made the former init function into a constructor
Also, 0 is a valid pin number
Also made the loggingInterval a consistent uint16_t (it was a mix of uint8_t and float)
I like the logger info better at the top, even if we create the logger at the bottom.
This was referenced May 24, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructuring! NOTE: This destroys backwards compatibility!!! Examples have been updated! Please update your code accordingly!
-CHANGED INHERITANCE - made a variable array and object within a logger rather than having a logger be a subclass of variable array. This based on principle "composition not inheritance"
Moved init functions to constructor, where possible (closing init vs begin #145)
Some clean-up and improvement of consistency between stream vs generate text functions.
Made an interrupt pin for testing mode part of a basic logger
Rewrote examples for new structures.