Add support for working with binary indexes. #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- checkout faiss commit referring to v1.8.0 - update gen_bindings.sh to use the latest bindgen version - update bindings.rs and bindings_gpu.rs
- no longer exists in Faiss 1.8.0
…macros for binary indexes. Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
Signed-off-by: Aalekh Patel <aalekh.gwpeck.7998@icloud.com>
aalekhpatel07
force-pushed
the
binary-indexes
branch
from
1d23e20 to
bd38fa6
Compare
Enet4
force-pushed
the
change/faiss-v1.8.0
branch
from
c990326 to
f0820cb
Compare
|
Hey @aalekhpatel07, I have merged #77 in the meantime, so please feel free to recreate the pull request onto the upstream branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to provide first-class support for Faiss binary indexes consuming the C API (along with a couple of utility functions introduced in Enet4/faiss#1)
PS: Still a WIP but I just wanted to have something to share in case I misunderstood something and was going down the wrong path.This should be complete in terms of functionality (at least for a default
BinaryIndexImpl) so I'm hoping to learn of any major concerns before continuing down this path and adding theIndexBinaryFlat,IndexBinaryHNSW, etc, concrete impls.