Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update storybook #305

Merged
merged 22 commits into from
Jan 26, 2022
Merged

Chore/update storybook #305

merged 22 commits into from
Jan 26, 2022

Conversation

frontend-specialisten
Copy link
Contributor

@frontend-specialisten frontend-specialisten commented Jan 24, 2022

Description

Update storybook to latest version due to security warning of immer:
storybookjs/storybook#16093

react-dom has been added to the resolutions as it otherwise won't be installed, by some reasons:
storybookjs/storybook#13194

If you have any suggestions how to fix this, it would be great!

References

https://github.com/Energinet-DataHub/greenforce-frontend/security/dependabot/yarn.lock/immer/closed

@frontend-specialisten frontend-specialisten temporarily deployed to Development January 24, 2022 07:16 Inactive
@frontend-specialisten frontend-specialisten temporarily deployed to Development January 24, 2022 11:05 Inactive
@frontend-specialisten frontend-specialisten temporarily deployed to Development January 25, 2022 07:53 Inactive
@LayZeeDK LayZeeDK temporarily deployed to Development January 25, 2022 14:02 Inactive
@frontend-specialisten frontend-specialisten marked this pull request as ready for review January 26, 2022 07:05
@frontend-specialisten frontend-specialisten temporarily deployed to Development January 26, 2022 07:10 Inactive
@sonarqubecloud
Copy link

[DH3 Frontend App] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@frontend-specialisten frontend-specialisten temporarily deployed to Development January 26, 2022 09:45 Inactive
@frontend-specialisten frontend-specialisten merged commit cd08343 into main Jan 26, 2022
@frontend-specialisten frontend-specialisten deleted the chore/update-storybook branch January 26, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants