Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightningd: fix crash when peer disconnects after fundchannel_start, before cancel/complete #2931

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

rustyrussell
Copy link
Contributor

Fixes: #2831

…before cancel/complete

Fixes: ElementsProject#2831
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Copy link
Contributor

@ZmnSCPxj ZmnSCPxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a615fd1

Looks ok to me, but I wonder if it is possible to add a test?

@cdecker cdecker merged commit 710d015 into ElementsProject:master Aug 9, 2019
@darosior
Copy link
Contributor

darosior commented Aug 9, 2019

@ZmnSCPxj I made one here rustyrussell#6 but was not quick enough ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fundchannel_complete crashes on peer_error?
4 participants