Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLW sometimes sends funding_locked before re-establish #2219

Closed
rustyrussell opened this issue Jan 3, 2019 · 2 comments · Fixed by #2373
Closed

BLW sometimes sends funding_locked before re-establish #2219

rustyrussell opened this issue Jan 3, 2019 · 2 comments · Fixed by #2373
Assignees
@rustyrussell
Labels
eclair-compat lnd-compat
Milestone
v0.7

Comments

@rustyrussell
Copy link
Contributor

Issue and Steps to Reproduce

{
"type": "UNUSUAL",
"time": "582.646173141",
"source": "lightningd(18552):",
"log": "033627ce012a83bb2fa87754ab2f35963d353b347d2b39a601599eb8d1f8c28576 chan #7: Peer permanent failure in CHANNELD_AWAITING_LOCKIN: lightning_channeld: sent ERROR bad reestablish msg: WIRE_FUNDING_LOCKED 0024a05b28d89ab50c4a7facd04d6c64ca7bde2835f57590eda6bc782063071d0b2102cabca945a66e3ae275d590e81bfbbc555ab157f907f5465522feb519a7738740 (tx 02e780ffa339db8b03994f13cc7871c1a6351ce7d2d202c952c4cac885d5ec1b)"
}

getinfo output
@akumaigorodski
Copy link

Could it possibly be anything else? Can't reproduce this, also BLW sends ChannelReestablish in response to Init and then FundingLocked in response to peer's ChannelReestablish within a single thread so it's always in that order.

@rustyrussell
Copy link
Contributor Author

Someone else reported it with LND, so perhaps that's it. Either way, will workaround for 0.7.

@rustyrussell rustyrussell added this to the v0.7 milestone Feb 19, 2019
@rustyrussell rustyrussell self-assigned this Feb 19, 2019
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Feb 20, 2019
@rustyrussell
channeld: handle funding_locked message before reestablish.
96aae09 
LND seems to do this occasionally, though fixed in new versions.  Workaround
in the meantime.

I tested this by hacking our code to send it prematurely, and this worked.

Fixes: ElementsProject#2219
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this issue Feb 20, 2019
Merged
cdecker pushed a commit that referenced this issue Feb 20, 2019
@rustyrussell @cdecker
channeld: handle funding_locked message before reestablish.
5f0b065 
LND seems to do this occasionally, though fixed in new versions.  Workaround
in the meantime.

I tested this by hacking our code to send it prematurely, and this worked.

Fixes: #2219
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
eclair-compat lnd-compat
Projects
None yet
Milestone
v0.7
Development

Successfully merging a pull request may close this issue.

channeld: handle funding_locked message before reestablish. rustyrussell/lightning
2 participants
@rustyrussell @akumaigorodski