Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5: Cohere Client Init #56

Merged
merged 14 commits into from
Jan 3, 2024
Merged

#5: Cohere Client Init #56

merged 14 commits into from
Jan 3, 2024

Conversation

mkrueger12
Copy link
Contributor

  • Created cohere client w/ unified response

  • Added test based off OpenAI test

@mkrueger12 mkrueger12 added area:providers area:tests Unit, integration and E2E tests and all that is related to them labels Jan 2, 2024
@mkrueger12 mkrueger12 self-assigned this Jan 2, 2024
@mkrueger12 mkrueger12 linked an issue Jan 2, 2024 that may be closed by this pull request
Setup Cohere Client #5
Closed
@mkrueger12 mkrueger12 changed the title 5 Cohere Client Init #5: Cohere Client Init Jan 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (8900b8d) 69.56% compared to head (4fd153d) 68.03%.

Files Patch % Lines
pkg/providers/cohere/chat.go 63.84% 38 Missing and 9 partials ⚠️
pkg/providers/cohere/config.go 63.63% 12 Missing ⚠️
pkg/providers/cohere/client.go 79.16% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #56      +/-   ##
===========================================
- Coverage    69.56%   68.03%   -1.54%     
===========================================
  Files            8       11       +3     
  Lines          276      463     +187     
===========================================
+ Hits           192      315     +123     
- Misses          71      125      +54     
- Partials        13       23      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkrueger12 mkrueger12 removed the request for review from roma-glushko January 3, 2024 22:19
@mkrueger12 mkrueger12 merged commit 2cf73a5 into develop Jan 3, 2024
5 of 7 checks passed
@mkrueger12 mkrueger12 deleted the 5-setup-cohere-client branch January 3, 2024 22:19
@roma-glushko roma-glushko mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkrueger12 mkrueger12

Labels
area:providers area:tests Unit, integration and E2E tests and all that is related to them
Projects
None yet
Milestone
Glide: Private Preview (MVP)
Development

Successfully merging this pull request may close these issues.

Setup Cohere Client
1 participant
@mkrueger12