Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Render all Durations as human-readable string #238

Closed
roma-glushko opened this issue May 5, 2024 · 4 comments
Closed

[Config] Render all Durations as human-readable string #238

roma-glushko opened this issue May 5, 2024 · 4 comments
Assignees
@ppmdo
Labels
api:http area:api area:config good first issue Good for newcomers help wanted Extra attention is needed model:language size:small type:enhancement New feature or request

Comments

@roma-glushko
Copy link
Member

Let's render all Durations like retry.min_delay, retry.max_delay, client.timeout as human-friendly strings (e.g. 5s):

2024-05-05_15-34-13
@ppmdo
Copy link
Contributor

ppmdo commented May 6, 2024

Hi, nice project!

I can take a look into this. Please assign it to me.

@roma-glushko
Copy link
Member Author

@ppmdo appreciate that Pablo 🙏

@daesu
Copy link
Contributor

daesu commented May 6, 2024

Apologies @roma-glushko @ppmdo I didn't see you had taken this. I have a PR here

ppmdo added a commit to ppmdo/glide that referenced this issue May 9, 2024
@ppmdo
Implements human readable durations in config, fixes EinStack#238
22c9dc9
ppmdo added a commit to ppmdo/glide that referenced this issue May 9, 2024
@ppmdo
Implements human readable durations in config, fixes EinStack#238
fbbf7ef
ppmdo added a commit to ppmdo/glide that referenced this issue May 9, 2024
@ppmdo
Implements human readable durations in config, fixes EinStack#238
6de012d
roma-glushko pushed a commit that referenced this issue May 22, 2024
@ppmdo
🔧 #238 Implements human readable durations in config (#253)
03f1805
@roma-glushko
Copy link
Member Author

Closed in #253 ✅

@roma-glushko roma-glushko mentioned this issue Jun 24, 2024
Merged
roma-glushko added a commit that referenced this issue Jun 24, 2024
@roma-glushko
📦 Release: v0.1.0-rc.1 (#280)
1e2b16f 
The first major update with breaking changes to the language chat schemas 
and begging of work on instrumenting the gateway with OpenTelemetry.

### Added

- 🔧 Use github.com/EinStack/glide as module name to support go install cmd (@gernest)
- ✨🔧 Setup Open Telemetry Metrics and Traces (#237) (@gernest)
-  🔧 #221 Add B3 trace propagator (#242) (@gernest)
- 🔧 #241 Support overriding OTEL resource attributes (#243) (@gernest)
- 🔧 #248 Disable span and metrics by default (#254) (@gernest)
- 🔧 #220 Instrument API server with observability signals (#255) (@gernest)
- 🔧 #164 Make client connection pool configurable across all providers (#251) (@daesu)
- 🔧 Instrument gateway process (#256) (@gernest)
- 🔧 #262: adding connection pool for chat request and response (#271) (@tom-fitz)

### Changed

- 🔧 #238 Implements human-readable durations in config (#253) (@ppmdo)
- 🔧 #266: removing omitempty from response definition (#267) (@tom-fitz)

#### Breaking Changes

- 🔧 💥 #235: Extended the non-streaming chat error schema with new fields to give clients more context around the error (#236) (@roma-glushko)
- 💥 Convert all camelCase config fields to the snake_case in the provider configs (#260) (@roma-glushko)
- ✨💥 #153: Allow to pass multiple model-specific param overrides (#264) (@roma-glushko)

### Fixed

- 🐛 #217: Set build info correctly in Glide images (#218) (@roma-glushko)

### Security

- 🔒 Updated golang to 1.22.4 to address CVE-2024-24790 (#276) (@STAR-173)

### Miscellaneous

- 📝 Defined a way to manage EinStack Glide project (#234) (@roma-glushko)
- 👷 #219: Setup local telemetry stack with Jaeger, Grafana, VictoriaMetrics and OTEL Collector (#225) (@roma-glushko)
- 👷‍♂️ Added a new GH action to watch for glide activity stream (#239, #244) (@roma-glushko)
- ✨ Switched to the new docs (@roma-glushko)
- 🔧 #240: Automatically install air (#277, #270) (@ppmdo, @roma-glushko)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppmdo ppmdo

Labels
api:http area:api area:config good first issue Good for newcomers help wanted Extra attention is needed model:language size:small type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daesu @roma-glushko @ppmdo