#153: Changed the default OpenAI model & applied a static role to the…

… stream deltas
EinStack · Jun 5, 2024 · bca8c8f · bca8c8f
1 parent e203ecd
commit bca8c8f
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/pkg/api/http/handlers.go b/pkg/api/http/handlers.go
@@ -137,6 +137,7 @@ func LangStreamChatHandler(tel *telemetry.Telemetry, routerManager *routers.Rout
 			var chatRequest schemas.ChatStreamRequest
 
 			if err = c.ReadJSON(&chatRequest); err != nil {
+				// TODO: handle bad request schemas gracefully and return back validation errors
 				if websocket.IsUnexpectedCloseError(err, websocket.CloseNormalClosure, websocket.CloseGoingAway) {
 					tel.L().Warn("Streaming Chat connection is closed", zap.Error(err), zap.String("routerID", routerID))
 				}

diff --git a/pkg/providers/bedrock/chat.go b/pkg/providers/bedrock/chat.go
@@ -103,7 +103,6 @@ func (c *Client) doChatRequest(ctx context.Context, payload *ChatRequest) (*sche
 		ModelName: c.config.ModelName,
 		Cached:    false,
 		ModelResponse: schemas.ModelResponse{
-			Metadata: map[string]string{},
 			Message: schemas.ChatMessage{
 				Role:    "assistant",
 				Content: modelResult.OutputText,

diff --git a/pkg/providers/openai/chat_stream.go b/pkg/providers/openai/chat_stream.go
@@ -120,7 +120,7 @@ func (s *ChatStream) Recv() (*schemas.ChatStreamChunk, error) {
 					"generated_at":       completionChunk.Created,
 				},
 				Message: schemas.ChatMessage{
-					Role:    responseChunk.Delta.Role,
+					Role:    "assistant", // doesn't present in all chunks
 					Content: responseChunk.Delta.Content,
 				},
 			},

diff --git a/pkg/providers/openai/config.go b/pkg/providers/openai/config.go
@@ -56,7 +56,7 @@ func DefaultConfig() *Config {
 	return &Config{
 		BaseURL:       "https://api.openai.com/v1",
 		ChatEndpoint:  "/chat/completions",
-		ModelName:     "gpt-3.5-turbo",
+		ModelName:     "gpt-4o",
 		DefaultParams: &defaultParams,
 	}
 }