Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): '---' option is missing when selecting some source values. #5913

Merged
merged 1 commit into from
Feb 15, 2025
Merged

fix(radio): '---' option is missing when selecting some source values. #5913

merged 1 commit into from
Feb 15, 2025

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Feb 14, 2025

Fixes #5912

Fix missing source option.

@philmoz philmoz added color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Feb 14, 2025
@philmoz philmoz added this to the 2.11 milestone Feb 14, 2025
@philmoz philmoz changed the title fix(radio): '---' options is missing when selecting some source values. fix(radio): '---' option is missing when selecting some source values. Feb 14, 2025
@inventor7777
Copy link

inventor7777 commented Feb 14, 2025 •
edited
Loading

That was fast! 💨

Thank you!

pfeerick
pfeerick approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... can't set sources or mixes to invalid "OFF" state, and telemetry values can be cleared now. :)

@pfeerick pfeerick merged commit 71c4f7b into main Feb 15, 2025
51 checks passed
@pfeerick pfeerick deleted the philmoz/fix-src-list branch February 15, 2025 01:38
@pfeerick pfeerick mentioned this pull request Feb 15, 2025
Open
pfeerick pushed a commit that referenced this pull request Feb 15, 2025
@philmoz @pfeerick
fix(radio): '---' option is missing when selecting some source values.(…
b5050e5 
…#5913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Unable to remove items from telemetry page.
3 participants
@philmoz @inventor7777 @pfeerick