Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add precision setting for mix delay up & down #5314

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Jul 20, 2024

Fixes #5296

@philmoz philmoz added this to the 2.11 milestone Jul 20, 2024
@philmoz philmoz added the enhancement ✨ New feature or request label Jul 20, 2024
@elecpower
Copy link
Collaborator

Hi Phil suggestion for alternative GUI layout that moves the precision fields into the Delay Slow table.

Screenshot from 2024-07-22 08-16-40

Alternative
Screenshot from 2024-07-22 08-23-14

@elecpower
Copy link
Collaborator

Phil this will likely be an ugly merge with #5220

@philmoz
Copy link
Collaborator Author

philmoz commented Jul 21, 2024

Hi Phil suggestion for alternative GUI layout that moves the precision fields into the Delay Slow table.

Done.

Phil this will likely be an ugly merge with #5220

I expect so.

@elecpower elecpower self-requested a review July 21, 2024 23:48
elecpower
elecpower previously approved these changes Jul 21, 2024
@elecpower
Copy link
Collaborator

Tested in Companion and tx16s libsim reading settings

@philmoz philmoz force-pushed the philmoz/mix-delay-prec branch from 29cebf6 to 420d3ac Compare July 25, 2024 23:58
@philmoz philmoz force-pushed the philmoz/mix-delay-prec branch 2 times, most recently from 1890963 to 4f603d2 Compare July 27, 2024 06:54
@philmoz philmoz force-pushed the philmoz/mix-delay-prec branch from 4f603d2 to 471a657 Compare July 28, 2024 01:03
@pfeerick pfeerick self-requested a review July 28, 2024 01:59
@pfeerick pfeerick changed the title feat(radio): add precision setting for mix delay up & down. feat(radio): add precision setting for mix delay up & down Jul 28, 2024
@pfeerick pfeerick changed the title feat(radio): add precision setting for mix delay up & down feat: add precision setting for mix delay up & down Jul 28, 2024
@pfeerick
Copy link
Member

pfeerick commented Jul 29, 2024

I'm pretty sure I passed grade 5 maths... something doesn't add up... 😆 1 & 3, 2 & 4 should be the same, no? The list matches what the values I entered on the TX, the dialog doesn't. 0.0 precision seems fine, 0.00 has the problem. Slow does not seem to be affected. Other than this gem, LGTM - T15 and TX12.

image

image

@pfeerick pfeerick added the rn: feature Feature to be highlighted in release notes label Jul 29, 2024
@philmoz
Copy link
Collaborator Author

philmoz commented Jul 29, 2024

I'm pretty sure I passed grade 5 maths... something doesn't add up... 😆 1 & 3, 2 & 4 should be the same, no? The list matches what the values I entered on the TX, the dialog doesn't. 0.0 precision seems fine, 0.00 has the problem. Slow does not seem to be affected. Other than this gem, LGTM - T15 and TX12.

Incorrect setting for # of decimal places in companion - should be ok now.

@pfeerick pfeerick merged commit bdfb94a into main Jul 29, 2024
50 checks passed
@pfeerick pfeerick deleted the philmoz/mix-delay-prec branch July 29, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request rn: feature Feature to be highlighted in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Higher precision delay up/dn
3 participants