fix(color): block radio startup until checklist is closed. #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philmoz
added
bug 🪲
|
Do not think this is a good idea. If one does a reset during flight and you have the reset flight in the reset your Tx will be off until you pass the checklist. You have now created a way to reboot Tx by doing a reset....not a good idea....reset should never kill your RF power. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents modules from being powered up until the checklist is closed.
Also sets the LED color to red while the checklist is open (to match B&W radios).
Note: this PR for 2.10, 2.11 is slightly different.