-
Notifications
You must be signed in to change notification settings - Fork 216
Adds additional machine details to query_config
#4759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d9fe0db
Adds vscode devcontainer.
jasonb5 b431d89
Adds vscode tasks.
jasonb5 b9ec3c7
Refactors print_values method
jasonb5 2aea5d1
Adds option to print compiler details for machine
jasonb5 a085291
Adds model devcontainers
jasonb5 3016724
Cleans up _print_machine_values
jasonb5 7175fdb
Fixes file formatting
jasonb5 659f93d
Refactors to generalized method to print children based on attribute …
jasonb5 087ce16
Fixes check if compiler argument is valid
jasonb5 6055f46
Fixes spelling error
jasonb5 49c259c
Fixes error message
jasonb5 a2fb387
Adds comments
jasonb5 ad868fa
Adds initial tests
jasonb5 f50de54
Adds tests
jasonb5 39130af
Fixes black formatting
jasonb5 c1147fb
Fixes failing test
jasonb5 af09a89
Fixes changes to frontier.
jasonb5 28de1bb
Merge branch 'master' into adds-query_config-compiler-info
jasonb5 21cd8ef
Removes vscode devcontainers and tasks.
jasonb5 fe49f5f
Fixes error message rather than exception
jasonb5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"containerEnv": { | ||
"CIME_MODEL": "cesm", | ||
"CIME_MACHINE": "docker", | ||
"SKIP_CIME_UPDATE": "true", | ||
"SKIP_MODEL_SETUP": "true" | ||
}, | ||
"build": { | ||
"dockerfile": "../../docker/Dockerfile", | ||
"target": "base" | ||
}, "workspaceFolder": "/src/cime", | ||
"workspaceMount": "source=${localWorkspaceFolder}/..,target=/src,type=bind", | ||
"postAttachCommand": "/entrypoint.sh bash", | ||
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"charliermarsh.ruff" | ||
] | ||
} | ||
}, | ||
"features": { | ||
"ghcr.io/devcontainers/features/git:1": {} | ||
} | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"containerEnv": { | ||
"CIME_MODEL": "cesm", | ||
"CIME_MACHINE": "docker", | ||
"SKIP_CIME_UPDATE": "true", | ||
"SKIP_MODEL_SETUP": "true" | ||
}, | ||
"image": "ghcr.io/esmci/cime:latest", | ||
"workspaceFolder": "/src/cime", | ||
"workspaceMount": "source=${localWorkspaceFolder}/..,target=/src,type=bind", | ||
"postAttachCommand": "/entrypoint.sh bash", | ||
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"charliermarsh.ruff" | ||
] | ||
} | ||
}, | ||
"features": { | ||
"ghcr.io/devcontainers/features/git:1": {} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"image": "ghcr.io/esmci/cime:latest", | ||
"forwardPorts": [8000], | ||
"mounts": [ | ||
"source=${localWorkspaceFolder}/../,target=/src,type=bind" | ||
], | ||
"postStartCommand": "pip install -r doc/requirements.txt; pip install sphinx-autobuild; cd doc/source; sphinx-autobuild --ignore '**/__pycache__' . ../build/html", | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"containerEnv": { | ||
"CIME_MODEL": "e3sm", | ||
"CIME_MACHINE": "docker", | ||
"SKIP_CIME_UPDATE": "true", | ||
"SKIP_MODEL_SETUP": "true" | ||
}, | ||
"build": { | ||
"dockerfile": "../../docker/Dockerfile", | ||
"target": "base" | ||
}, | ||
"workspaceFolder": "/src/cime", | ||
"workspaceMount": "source=${localWorkspaceFolder}/..,target=/src,type=bind", | ||
"postAttachCommand": "/entrypoint.sh bash", | ||
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"charliermarsh.ruff" | ||
] | ||
} | ||
}, | ||
"features": { | ||
"ghcr.io/devcontainers/features/git:1": {} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{ | ||
"containerEnv": { | ||
"CIME_MODEL": "e3sm", | ||
"CIME_MACHINE": "docker", | ||
"SKIP_CIME_UPDATE": "true", | ||
"SKIP_MODEL_SETUP": "true" | ||
}, | ||
"image": "ghcr.io/esmci/cime:latest", | ||
"workspaceFolder": "/src/cime", | ||
"workspaceMount": "source=${localWorkspaceFolder}/..,target=/src,type=bind", | ||
"postAttachCommand": "/entrypoint.sh bash", | ||
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"charliermarsh.ruff" | ||
] | ||
} | ||
}, | ||
"features": { | ||
"ghcr.io/devcontainers/features/git:1": {} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
"version": "2.0.0", | ||
"tasks": [ | ||
{ | ||
"label": "Build docs", | ||
"type": "shell", | ||
"command": "make html", | ||
"options": { | ||
"cwd": "${workspaceFolder}/doc" | ||
}, | ||
}, | ||
{ | ||
"label": "Autobuild docs", | ||
"type": "shell", | ||
"command": "sphinx-autobuild --ignore '**/__pycache__' . ../build/html", | ||
"options": { | ||
"cwd": "${workspaceFolder}/doc/source" | ||
} | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these container changes part of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yea I'll pull that out and make a separate PR. It's some additional dev stuff for anyone using vscode to simplify running/testing in a container locally. @jedwards4b @jgfouca Any issue if I add this in a different PR? It doesn't affect anything unless you're using vscode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't care if you keep it in this PR as long as we understand why it's there and you add it to the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to pull it out of this PR. I'll be making a more testing focused PR soon, it'll fit in better there and I can provide a full explanation.