Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow partial matches in xmlquery #947

Closed
billsacks opened this issue Dec 21, 2016 · 0 comments
Closed

Allow partial matches in xmlquery #947

billsacks opened this issue Dec 21, 2016 · 0 comments
Assignees
@jedwards4b @jgfouca
Labels
ty: enhancement

Comments

@billsacks
Copy link
Member

It would be nice if xmlquery allowed matches on partial variable names - e.g., query for all names matching 'STOP_*'.

This request is motivated by a discussion I had with @mvertens , in which we both confessed that we generally use grep rather than xmlquery. Reflecting on this, I think the main reason is that I often forget the full variable name, so grep on a piece of this. I'd be able to use xmlquery more if it supported partial matches.

I'm not sure exactly how this should be implemented: Should you explicitly give the wildcard characters? Or should it do partial matches by default? Should there be a flag that allows partial matches, or conversely a flag that forces exact matches? I'm happy to iterate on these details with others.

cc @mvertens @jedwards4b
@jgfouca jgfouca self-assigned this Jan 27, 2017
@rljacob rljacob added the ready label Jan 27, 2017
@rljacob rljacob closed this as completed in 263b2af Feb 8, 2017
@ghost ghost assigned rljacob Feb 8, 2017
@ghost ghost removed the ready label Feb 8, 2017
@jgfouca jgfouca reopened this Feb 8, 2017
@rljacob rljacob removed their assignment Feb 8, 2017
@jgfouca jgfouca added the ready label Feb 9, 2017
@jgfouca jgfouca mentioned this issue Feb 9, 2017
Merged
@ghost ghost added in progress and removed ready labels Feb 9, 2017
@ghost ghost assigned jedwards4b Feb 10, 2017
@ghost ghost removed the in progress label Feb 10, 2017
jedwards4b added a commit that referenced this issue Feb 10, 2017
@jedwards4b
Merge pull request #1128 from ESMCI/jgfouca/xmlquery_partial_match
a51fb8c 
xmlquery: allow partial match of variable name
The new -p flag turns on this capability.

I also added some usage examples to the help.

I also made it so --listall would take --subgroup into account
if it was provided too.

Test suite: code_checker + by-hand + J_TestCreateNewcase
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #947

User interface changes?: -p flag to xmlquery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedwards4b jedwards4b

@jgfouca jgfouca

Labels
ty: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rljacob @jedwards4b @billsacks @jgfouca