Adds a section to describe using shortDOI service #121
Conversation
There was a problem hiding this comment.
Overall this looks great. See wording change suggested below. My only substantive comment is that I was surprised that you put the sameAs inside identifier rather than as a property of Dataset, which is where the other sameAs is located. Is that only for short DOIs, or are you proposing that we move all sameAs statements? I think they are better listed as properties of Dataset, indicating that there are multiple identifiers that should be treated as equivalent for the purposes of this Dataset.
guides/Dataset.md
Outdated
|
|
||
| `schema:sameAs` is used here for the following reasons: | ||
|
|
||
| 1. It doesn't add too many more statements that might the page weight (which may impact major search engine crawlers stopping the crawl of schema.org markup). |
There was a problem hiding this comment.
should be: "that might increase the page weight..."
There was a problem hiding this comment.
ah yeah good question. My first thought was that since shortDOI is dependent on the original DOI, the sameAs should go on the DOI directly since its an identifier. Otherwise, why not just put all identifier URIs in the sameAs on the Dataset? And maybe we should do that?
But happy to update and switch to the Dataset.
There was a problem hiding this comment.
I think having them in one place (all as Dataset properties) makes the whole thing easier to process. Otherwise we have a sameAs that makes an instance of Identifier equivalent to an instance of Dataset.
There was a problem hiding this comment.
Isn't the short DOI an Identifier, not a Dataset? it seems strange to make this equivalence on behalf of harvesters to me. i must be misundertanding something though. my brain ain't working today
There was a problem hiding this comment.
ah, i see what you are saying. just resolved the schema.org fo rthe short DOI again, and it does come back types as Dataset. ok, cool. i'll change it here. sorry!
|
Looks good to me, thanks for the changes. |
|
@ashepherd I think this short DOI support looks good now, and I tested it in the JSON-LD playground and it worked well. So, unless there are other reviews, I think we can go ahead and merge this PR. If nobody comments tomorrow, I will go ahead and do so. |
Adds section to Dataset guideline to show how a short DOI URL should be described. Also updated the full dataset.jsonld example with a shortDOI URL in the schema:sameAs property of a schema:PropertyValue Identifier for an original DOI.
References #120