Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langmuir turbulence parameterization - PR polishing #11

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA commented Sep 15, 2023

Pull Request Summary

Polishing edits and cleanup for existing Langmuir mixing PR.

Description

What bug does it fix, or what feature does it add?

  • Some small cleanup in added regtest ww3_tp2.22 -- unnecessary config files removed from input/.
  • documentation added to model/inp/ww3_grid.inp.
  • run test calls added by modifying: matrix.base, and matrix_cmake_ncep (note: regarding matrix.base, there are only a few lines of new code added, though there are apparently a lot of trailing whitespace auto-removed by my editor as well).

Is a change of answers expected from this PR?

  • No.

Please also include the following information:

  • Mention any labels that should be added:
    • enhancement
  • Are answer changes expected from this PR?
    • No. Only documentation added and organizational cleanup done for regtest ww3_tp2.22.

Issue(s) addressed

NA.

Commit Message

Langmuir mixing PR polishing

Check list

Testing

  • How were these changes tested?
    • ww3_tp2.22 verified. Testing will continue in the UFS WM.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
    • Yes, the new regtest added (ww3_tp2.22) in the main PR.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
    • No. The matrix is not run for WW3 branch, dev/ufs-weather-model.
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
    • No.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
    • NA.

Copy link
Member

@alperaltuntas alperaltuntas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alperaltuntas alperaltuntas merged commit 3d39cf0 into ESCOMP:sync-dev/unified Sep 19, 2023
@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the regtest/sync-dev/unified branch September 20, 2023 20:35
francescococetta pushed a commit to francescococetta/WW3 that referenced this pull request Sep 26, 2023
…vforpr888

Merge Develop with conflict fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants