Error in CAM for a CAM4/CAM5 test

[ekluzek]

Brief summary of bug

For " ./create_test ERP_Lh12.f19_f19_mg17.FW4madSD.derecho_intel.cam-outfrq3h"

General bug information

**CTSM version you are using:**ctsm5.2.005
Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: Running in F compset with either CAM4 or CAM5

Details of bug

the list of LND_TUNING_MODE is incorrect for CAM4 and CAM5. The list has:

'clm5.0_cam5.0', 'clm5.0_cam4.0'

which should be:

'clm5_0_cam5.0', 'clm5_0_cam4.0'

So replacing "." with "_". It looks like the clm4_5, and clm6_0 versions are correct. clm5_1 is missing a CAM4/CAM5 option, but clm5_1 is deprecated so may be OK.

Important output or errors that show the problem

    Errors were:
        ERROR: Did not find clm5_0_cam4.0 in valid values for LND_TUNING_MODE: ['clm5_0_cam6.0', 'clm5_0_cam7.0', 'clm5.0_cam5.0', 'clm5.0_cam4.0', 'clm5_0_GSWP3v1', 'clm5_0_CRUv7', 'clm5_0_QIAN', 'clm5_0_1PT', 'clm5_0_NLDAS2', 'clm5_0_ERA5', 'clm4_5_CRUv7', 'clm4_5_GSWP3v1', 'clm4_5_QIAN', 'clm4_5_cam6.0', 'clm4_5_cam7.0', 'clm4_5_cam5.0', 'clm4_5_cam4.0', 'clm4_5_1PT', 'clm4_5_NLDAS2', 'clm4_5_ERA5', 'clm5_1_CRUv7', 'clm5_1_GSWP3v1', 'clm5_1_cam6.0', 'clm5_1_QIAN', 'clm5_1_1PT', 'clm5_1_NLDAS2', 'clm5_1_ERA5', 'clm6_0_CRUv7', 'clm6_0_GSWP3v1', 'clm6_0_cam6.0', 'clm6_0_cam7.0', 'clm6_0_cam5.0', 'clm6_0_cam4.0', 'clm6_0_QIAN', 'clm6_0_1PT', 'clm6_0_NLDAS2', 'clm6_0_ERA5']

[ekluzek]

@cacraigucar found this problem. The closest test we have to catch this is:

SMS_Ln9.f10_f10_mg37.I2000Clm50Sp.derecho_gnu.clm-clm50cam5LndTuningModeZDustSoilErod

Which passed.

Here's the fix:

diff --git a/cime_config/config_component.xml b/cime_config/config_component.xml
index be6916ae0..d69bdbc30 100644
--- a/cime_config/config_component.xml
+++ b/cime_config/config_component.xml
@@ -78,7 +78,7 @@
     </desc>
     <default_value>UNSET</default_value>
     <!-- 10 forcing options for each CLM physics option: CRUv7, GSWP3, cam7.0, cam6.0, cam5.0, cam4.0, QIAN, 1PT, NLDAS2, ERA5 -->
-    <valid_values>clm5_0_cam6.0,clm5_0_cam7.0,clm5.0_cam5.0,clm5.0_cam4.0,clm5_0_GSWP3v1,clm5_0_CRUv7,clm5_0_QIAN,clm5_0_1PT,clm5_0_NLDAS2,clm5_0_ERA5,clm4_5_CRUv7,clm4_5_GSWP3v1,clm4_5_QIAN,clm4_5_cam6.0,clm4_5_cam7.0,clm4_5_cam5.0,clm4_5_cam4.0,clm4_5_1PT,clm4_5_NLDAS2,clm4_5_ERA5,clm5_1_CRUv7,clm5_1_GSWP3v1,clm5_1_cam6.0,clm5_1_QIAN,clm5_1_1PT,clm5_1_NLDAS2,clm5_1_ERA5,clm6_0_CRUv7,clm6_0_GSWP3v1,clm6_0_cam6.0,clm6_0_cam7.0,clm6_0_cam5.0,clm6_0_cam4.0,clm6_0_QIAN,clm6_0_1PT,clm6_0_NLDAS2,clm6_0_ERA5</valid_values>
+    <valid_values>clm5_0_cam6.0,clm5_0_cam7.0,clm5_0_cam5.0,clm5_0_cam4.0,clm5_0_GSWP3v1,clm5_0_CRUv7,clm5_0_QIAN,clm5_0_1PT,clm5_0_NLDAS2,clm5_0_ERA5,clm4_5_CRUv7,clm4_5_GSWP3v1,clm4_5_QIAN,clm4_5_cam6.0,clm4_5_cam7.0,clm4_5_cam5.0,clm4_5_cam4.0,clm4_5_1PT,clm4_5_NLDAS2,clm4_5_ERA5,clm5_1_CRUv7,clm5_1_GSWP3v1,clm5_1_cam6.0,clm5_1_QIAN,clm5_1_1PT,clm5_1_NLDAS2,clm5_1_ERA5,clm6_0_CRUv7,clm6_0_GSWP3v1,clm6_0_cam6.0,clm6_0_cam7.0,clm6_0_cam5.0,clm6_0_cam4.0,clm6_0_QIAN,clm6_0_1PT,clm6_0_NLDAS2,clm6_0_ERA5</valid_values>
     <values match="last">
       <!-- Options for atm forcing are: CRU, CRUv7, GSWP3, cam6.0 (also used for DATM%CPLHIST), cam5.0, cam4.0, QIAN, WISOQIA, 1PT, NLDAS2, and ERA5) -->
       <!-- All the clm4_5 physics options -->