-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_3_150: Adding convective gustiness to U10: Add UGUST output to CAM #943
Conversation
This PR will need an update to Externals.cfg for the CMEPS external. @jedwards4b says this is currently cmeps0.14.48, but recent discussions indicate that another tag may be made. |
I believe the CMEPS external will now be cmeps0.14.49. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nitpick, but looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CMEPS external needs to be added to this PR.
This appears to only be adding a diagnostic variable at the CAM level. If that is the case, this is fine. If it does somehow change answers for cam_dev runs (due to the CMEPS external update), then a way to turn this on/off via a namelist might need to be introduced.
The CAM mods are mostly to add the diagnostic variable, but it's true that for that to work I should have updated the externals - I think I've done that here. There's a namelist option to turn the gusts on/off, which is set in usr_nl_cpl (add_gust) |
Merge pull request ESCOMP#943 from megandevlan/gustMods
Merge pull request ESCOMP#943 from megandevlan/gustMods cam6_3_150: Adding convective gustiness to U10: Add UGUST output to CAM ESCOMP commit: f9b91b9
Closes #540
This corresponds to issue #540, and CMEPS ESCOMP/CMEPS#267 (pull request for CMEPS side - ESCOMP/CMEPS#422).
Adding convective gusts to U10 occurs in the coupler, but the added magnitude (UGUST) needs to be output in CAM; these mods enable that.
Run to confirm the impact of this change is at: NCAR/amwg_dev#440