Create-alarabiya.net.xml

[ghost]

The english.alarabiya.net seem to use https by default. enawafeth.alarabiya.net was not included because SSL_ERROR_BAD_CERT_DOMAIN error.
https://www.ssllabs.com/ssltest/analyze.html?d=enawafeth.alarabiya.net&s=68.142.93.254&ignoreMismatch=on
https://www.ssllabs.com/ssltest/analyze.html?d=enawafeth.alarabiya.net&s=68.142.93.133&ignoreMismatch=on

Also urdu.alarabiya.net have some mixed content on page due to alarabiya.net ( https://imgur.com/YVZXO4d ), but that should be fixed by adding alarabiya.net to the list, right?

[jeremyn]

Thanks for your second ruleset. I hope you stay and become a regular contributor.

Your ruleset has some style and other problems. Please review the following links:

https://www.eff.org/https-everywhere/rulesets
https://github.com/EFForg/https-everywhere/blob/master/ruleset-style.md
https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md

I'm sorry that our documentation is spread out like that.

Note that the host for a target does not include subdomains. So for example, you need to include a target for www.alarabiya.net if you want the ruleset to cover it. Also, there is an test automatically created for each target, so once you add a target for www.alarabiya.net, you don't need to add a test for it.

[ghost]

Thank you, @jeremyn . It seems alarabiya.net alone doesn't exist and that was causing errors.

[jeremyn]

Thanks. Please make the following changes. For the various "Mark as" issues, please mark them in a new comment at the top like you see in this ruleset example. Note that you should not include https:// in the comment.

Mark as Different HTTP/HTTPS content:

• https://wowza.alarabiya.net

Mark as Invalid certificate:

• https://aia.alarabiya.net
• https://static.ana-ara.alarabiya.net
• https://enawafeth.alarabiya.net
• https://estudies.alarabiya.net
• https://images.alarabiya.net
• https://media.alarabiya.net
• https://mediasphere.alarabiya.net
• https://mobile.alarabiya.net
• https://nawafeth.alarabiya.net
• https://podcast.alarabiya.net
• https://studies.alarabiya.net
• https://vod.alarabiya.net

Mark as Refused:

• https://survey.alarabiya.net

Mark as Time out:

• https://alarabiya.net
• https://anaara.alarabiya.net
• https://apisaic.alarabiya.net
• https://api.cal.alarabiya.net
• https://www.english.alarabiya.net
• https://saic.alarabiya.net
• https://api.saic.alarabiya.net

Add target:

• https://api.alarabiya.net
• https://feed.alarabiya.net
• https://kukurap.alarabiya.net
• https://mubasher.alarabiya.net
• https://spectator.alarabiya.net
• https://static.alarabiya.net
• https://webapps.alarabiya.net

Also:

• Change the ruleset name to Al Arabiya, without the dash, because this is how it spells itself on the English language page
• In all cases where there is a list of domains, sort them in alphabetical order starting from the top level domain at the right reading left, moving ^ and www to the top of their group. For example:

Click to expand sort order example

example.com
www.example.com
a.example.com
www.a.example.com
b.a.example.com
b.example.com
example.net
www.example.net
a.example.net

[jeremyn]

Also, for future reference, see here for suggestions on finding subdomains: #6681 (comment) , #7277 .

[ghost]

Should be fine now. Sorry about the mess.

[jeremyn]

No problem. alarabiya.net.xml looks fine now. Do you mind if I delete all of the commit messages from the squashed commit message?

Also, please remove digikala.com.xml and make a new pull request for it. Going forward, you may want to submit pull requests under branches other than master.

[ghost]

Do you mind if I delete all of the commit messages from the squashed commit message?

Sure. You may delete it.

Also, please remove digikala.com.xml and make a new pull request for it

I was going to do that, but made something wrong. It's okay now?

[jeremyn]

Yes, it's fine now, thanks. Merged.