Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Enable for www.montereybayaquarium.org #7323

Merged
merged 5 commits into from
Oct 14, 2016

Conversation

illicitonion
Copy link
Contributor

The cert is only valid for www., so exclude the bare host.

The cert is only valid for www., so exclude the bare host.
@jeremyn
Copy link
Contributor

jeremyn commented Oct 12, 2016

Thanks for the ruleset. If there is no target for a domain like montereybayaquarium.org, then it won't be matched and you don't need to add an exclusion for it.

@jeremyn
Copy link
Contributor

jeremyn commented Oct 13, 2016

Thanks. Please make the following changes. The ruleset should look something like this one when you're done.

Mark as Invalid certificate:

Mark as Time out:

Add target:

Also:

  • Delete this test, because there is an implicit test created for the target already. See the style guide for more information.
  • Change the securecookie host to ^(www|affiliate|m|mobile|newsroom|tickets)\.montereybayaquarium\.org$

Finally, we like to squash and merge pull requests, which means we combine and rewrite pull requests in your name. Is that all right with you for this and any other pull requests you submit to us?

@jeremyn jeremyn self-assigned this Oct 13, 2016
@illicitonion
Copy link
Contributor Author

Thanks for taking the time :) I think everything's done now.

Happy to be squashed and merged.

For future reference, how did you generate that list of domains?

@jeremyn
Copy link
Contributor

jeremyn commented Oct 13, 2016

Thanks, I've updated the checklist through 6edf1dc . The securecookie host should have a trailing $, which was not in my original checklist, so it's my fault you didn't have it. I've updated the checklist accordingly.

Also we normally only have e.g. tmp.montereybayaquarium.org in the top comment, not https://tmp.montereybayaquarium.org so please change that. I include https:// to make it easy to click on from the GitHub comment but I understand how that might be confusing.

You can find those domains using the Google search trick, Sublist3r, and knowing that if m. is a domain, then mobile. might be too.

@jeremyn jeremyn merged commit a16148d into EFForg:master Oct 14, 2016
@jeremyn
Copy link
Contributor

jeremyn commented Oct 14, 2016

Thanks, merged.

@jeremyn jeremyn removed their assignment Oct 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants