-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
@jeremyn I have tried to clear the comments. |
@@ -1,22 +1,45 @@ | |||
<!-- | |||
Might be blocked by The Great Fire Wall (GFW) in China, Check error: Connection timed out ( after 20000 milliseconds ). | |||
|
|||
- Might be blocked by The Great Fire Wall (GFW) in China, Check error: Connection timed out ( after 20000 milliseconds ). | |||
Test in Tor broswer 6.0.4, Ok by http, however, unable to connect to https. | |||
Users could turn on this rule to test by youself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fix: you(r)self
@ivysrono I saw your frustration about this issue in #7242 (comment) . This looks really tough to review for reasons like:
Please note I'm not asking you to answer these questions right now, I'm just showing you some things I see as a reviewer that make this PR look very hard or impossible to review for me. Unfortunately, because we have a lot of open PRs, "difficult" PRs can get overlooked. For this specific PR, I don't know if anyone with merge access is able to review this correctly, because it looks so specific to the Chinese internet. I know that's not fair to you. We should have a wider range of volunteers, including reviewers, from more countries, for example see the discussion starting at #6424 (comment) . |
@jeremyn In this case, I don't know the details of GFW, but use VPN that operating in mainland China is more acurrate than MO/HK/TW. It's quite complex and I don't want to talk too much on it. For RSS and pic, they are unofficial things. There are some privacy issues, and I'm not sure it is okay or not. |
Thanks @gloomy-ghost , but I want to again emphasize that my last comment was just to explain to @ivysrono why this PR seems difficult to review and so why it might be getting "ignored". I'm not volunteering to review this one myself and I don't want @ivysrono to put a ton more effort into this and get disappointed. |
@jeremyn First of all, thank you very much for your patience. |
This PR is special in different ways. I'm not sure what you're asking. Can you ask your question in a new issue? |
No description provided.