-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
Bisaloo
commented
Jun 4, 2016
- Add new subdomains
- Follow new style guidelines
- Add new subdomains - Follow new style guidelines
I edited from a branch that wasn't up-to-date. What can I do to solve this conflict? Well, actually, my changes were using done from the latest EFForg/master version, I just didn't fork from this version. Sorry about that, I am still kinda new to this. |
You can use |
@Bisaloo Are you still interested in working on this? |
@jeremyn sorry for taking so long, it can be merged now (unless you have suggestions). I am just unsure what should be done about private subdomains like https://repos.archlinux.org |
Thanks. Please make the following changes:
<!--
Invalid certificate:
alberich.archlinux.org
apollo.archlinux.org
aur-dev.archlinux.org
aur4.archlinux.org
gudrun.archlinux.org
orion.archlinux.org
quassel.archlinux.org
rsync.archlinux.org
soyuz.archlinux.org
static.archlinux.org
tracker.archlinux.org
No working URL known:
repos.archlinux.org (403)
stats.archlinux.org (401)
Refused:
mail.archlinux.org
mx.archlinux.org
nymeria.archlinux.org
-->
<rule from="^http://(aur-dev|tracker)\.archlinux\.org/"
to="https://bbs.archlinux.org/" />
In this specific ruleset, please move the
<securecookie host="^(archive\.|aur\.|bbs\.|bugs\.|dev\.|git\.|lists\.|luna\.|mailman\.|master-key\.|packages\.|patchwork\.|planet\.|projects\.|releng\.|security\.|sources\.|tracker\.|wiki\.|www\.)archlinux.org" name=".+" />
|
I think that's it. Thank you for your help! I haven't included in the comment URLs found by Regarding your last two points, yes, it's fine by me. |
Thanks @Bisaloo. Can you please however move the top comment outside of the Also, for
I'm not sure what you mean. Can you give an example? |
Should I add
Otherwise, it's not actually a 404 but I don't know what to do with domains found by sublist3r like
|
I see what you mean. There's some judgment involved here. I don't want to mention subdomains that refuse to connect even with plain HTTP like http://celestia.archlinux.org or http://dom0.archlinux.org. Also there's a sort of a sequence of potential errors, and if both HTTPS and plain HTTP error but HTTPS errors earlier in the sequence, then you might mention that. For example http://mail.archlinux.org gets a The main reason, in my opinion, that we even list nonworking subdomains is to give information to the next person that looks at the ruleset. They may have a list of subdomains in mind and we want them to know what we've already considered and why some didn't get made into Anyway I've updated the top comment in the checklist with some new subdomains, so please feel free to drop that in, or ask me if you have questions. |
I agree with you about adding as much as possible in the comment in order to help the next person looking at the ruleset. I trust your judgment on this and I updated the top comment according to your recommendation. |
Thanks for catching that I left out I've also added one new item to the checklist about the |
I wouldn't have thought about that but that makes perfect sense. |
Thanks. Can you please also remove the extra tab from the beginning of this line? |
Thanks again, merged. |