Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Improve CONTRIBUTING.md #13757

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Improve CONTRIBUTING.md #13757

merged 2 commits into from
Mar 9, 2018

Conversation

brainwane
Copy link
Contributor

Suggest RegExr, and fix minor stylistic issues.

I'm totally open to resplitting this into multiple commits, revising it, and so on. :)

Suggest RegExr, and fix minor stylistic issues.
@brainwane brainwane requested a review from jeremyn November 26, 2017 02:06
@jeremyn
Copy link
Contributor

jeremyn commented Nov 26, 2017

@brainwave Thanks for the update.

I would prefer we not recommend RegExr, or anything else like that. It can come across like an endorsement, both us endorsing them and vice versa, which may cause problems. It might also obligate us as maintainers to help contributors troubleshoot it.

(Also, I personally tend to use https://regex101.com/ for regex checking. I don't know what the other maintainers use.)

Just as an FYI, you might find issue #7277 interesting, where we discussed mentioning Sublist3r, another third-party tool.

@J0WI J0WI added the docs label Dec 22, 2017
@brainwane
Copy link
Contributor Author

Ready for re-review.

@jeremyn jeremyn closed this Mar 9, 2018
@jeremyn jeremyn reopened this Mar 9, 2018
@jeremyn jeremyn merged commit 3a6359b into EFForg:master Mar 9, 2018
@jeremyn
Copy link
Contributor

jeremyn commented Mar 9, 2018

Thanks, merged.

@brainwane brainwane deleted the contributing branch August 17, 2019 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants