Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify executable_opts with new variable user_executable_opts #249

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

smoors
Copy link
Collaborator

@smoors smoors commented Mar 3, 2025

this PR adds a new variable user_executable_opts to the EESSI_Mixin class, which users can specify on the cmd line. advantages:

  • gives users full control of the executable options: it will completely override the ones set in the test
  • simplifies the tests: no more annoying check_custom_executable_opts(self, num_default=num_default) and has_custom_executable_opts
  • consistency: some tests were using check_custom_executable_opts and has_custom_executable_opts, others were not.

Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea of this one. It does indeed simplify the hooks.check_custom_executable_opts etc.

I think we should also remove that hook, as it shouldn't be used again. I think it's the only hook related to this specific change, right? (if there are more, all should probably be removed).

FYI: haven't tested yet... I'll do that once the changes are final

@smoors smoors requested a review from casparvl March 4, 2025 22:55
Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested this with:

reframe -c eessi/testsuite/tests/apps/tensorflow/tensorflow.py  -t CI -t 1_8_node --run --system=snellius:rome --setvar=user_executable_opts='--device gpu --intra-op-parallelism 16 --inter-op-parallelism 1'

Which (as intended) fails with an error because these nodes don't contain a GPU device. So: it respected the user_executable_opts I set.

I will double check with a regular run (setting no user_executable_opts) that the modified tests still run correctly before I merge, but all looks fine to me.

@casparvl
Copy link
Collaborator

casparvl commented Mar 5, 2025

Hm, also here a conflict. It's ready to be merged once the conflict is resolved :)

@smoors smoors requested a review from casparvl March 5, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants