-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify executable_opts with new variable user_executable_opts #249
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea of this one. It does indeed simplify the hooks.check_custom_executable_opts
etc.
I think we should also remove that hook, as it shouldn't be used again. I think it's the only hook related to this specific change, right? (if there are more, all should probably be removed).
FYI: haven't tested yet... I'll do that once the changes are final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I tested this with:
reframe -c eessi/testsuite/tests/apps/tensorflow/tensorflow.py -t CI -t 1_8_node --run --system=snellius:rome --setvar=user_executable_opts='--device gpu --intra-op-parallelism 16 --inter-op-parallelism 1'
Which (as intended) fails with an error because these nodes don't contain a GPU device. So: it respected the user_executable_opts
I set.
I will double check with a regular run (setting no user_executable_opts
) that the modified tests still run correctly before I merge, but all looks fine to me.
Hm, also here a conflict. It's ready to be merged once the conflict is resolved :) |
this PR adds a new
variable
user_executable_opts
to theEESSI_Mixin
class, which users can specify on the cmd line. advantages:check_custom_executable_opts(self, num_default=num_default)
andhas_custom_executable_opts
check_custom_executable_opts
andhas_custom_executable_opts
, others were not.