feat: Add existing and new Celery scripts to version control #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds previously unversioned crontab and celery worker scripts, facilitating better tracking and management of task scheduling and execution in LSF environments.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Introduce existing and new Celery scripts to the repository.
Why?
Without version control, tracking changes and discussing modifications to these scripts is challenging. Adding them to GitHub allows for better historical tracking and collaborative development.
How?
The integration includes pre-existing scripts used in the LSF environment. Celery workers are managed through
celery_worker_scripts/<env>/START_CELERY_WORKERS.sh, which are refreshed every three days via crontab usingcelery_worker_scripts/<env>/start_celery_worker.sh. For the upcoming SLURM migration, new scripts ending in_SLURM.shor_slurm.share added, alongside the implementation of scrontab to manage these tasks.Testing?
In the development environment, the scripts are tested with shorter cron intervals (2-3 minutes) to ensure functionality. One can test validation as well since the NF executor name is set to
slurmnow.For production, initiating scrontab before the data release won't impact the current LSF setup, allowing for a safe testing environment. Monitoring the health of celery workers post-implementation will be key to ensuring successful deployment.
Also see EBISPOT/goci#1179