Fix deprecation warning on Faraday::Connection#authorization #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Dwolla#59 > WARNING: `Faraday::Connection#authorization` is deprecated; it will be removed in version 2.0. > While initializing your connection, use `#request(:authorization, ...)` instead. > See https://lostisland.github.io/faraday/middleware/authentication for more usage info. Followed the docs at https://lostisland.github.io/faraday/middleware/authentication which as noted the Bearer auth implementation is *unchanged* between v1 and v2. The v1 approach is listed at the bottom while the current docs are for v2 which is unreleased.
javierjulio
force-pushed
the
fix-faraday-deprecation
branch
from
c3e9d3e to
6facc4b
Compare
|
Since we have extensive tests with our Dwolla integration, I can easily replicate the deprecation warning output by running our test suite. Once I apply this one line change as a monkey patch and re-run the tests, no deprecations are reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #59 so library users can update to Faraday v1 with no deprecations reported.
Closes #59