Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxNumberOfResourcesError #54

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Add MaxNumberOfResourcesError #54

merged 1 commit into from
Nov 24, 2020

Conversation

paulyeo21
Copy link
Contributor

@paulyeo21 paulyeo21 commented Nov 23, 2020

Add MaxNumberOfResourcesError (which happens when creating a funding source and a customer account has more than the allotted number of active funding sources) with a test case in the errors spec.

@paulyeo21
Copy link
Contributor Author

@sausman not sure why the ci is failing here (the test case passes locally)

@sausman
Copy link
Contributor

sausman commented Nov 24, 2020

@sausman not sure why the ci is failing here (the test case passes locally)

Sorry about that @paulyeo21, it should pass once we get #55 merged. Had a couple issues with the CI setup.

This looks good tho, thanks for the PR! We'll work on getting this out there.

@sausman
Copy link
Contributor

sausman commented Nov 24, 2020

@paulyeo21 Just got #55 merged! When you get a chance, could you merge main into this branch?

@paulyeo21
Copy link
Contributor Author

@paulyeo21 Just got #55 merged! When you get a chance, could you merge main into this branch?

Yeup! should be good now

@sausman sausman self-requested a review November 24, 2020 19:57
@sausman sausman merged commit 2ee926d into Dwolla:main Nov 24, 2020
@sausman
Copy link
Contributor

sausman commented Nov 24, 2020

Aight, this is out w/ v3.1.0! Thanks again

@arkadiysudarikov
Copy link

Thank you team! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants