Skip to content

Commit

Permalink
Drop support for rubocop < 1.50
Browse files Browse the repository at this point in the history
  • Loading branch information
fatkodima committed Jun 19, 2024
1 parent 3b8016f commit 8dcdeb8
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ jobs:
matrix:
ruby: ["3.0", 3.1, 3.2, 3.3]
gemfile: [
"gemfiles/rubocop_1.0.gemfile",
"gemfiles/rubocop_1.59.gemfile",
"gemfiles/rubocop_1.50.gemfile",
"gemfiles/rubocop_latest.gemfile",
"gemfiles/rubocop_edge.gemfile"
]

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
ruby-version: 3.0
- name: Lint Ruby code with RuboCop
run: |
bundle install --gemfile gemfiles/style.gemfile --jobs 4 --retry 3
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
/spec/reports/
/tmp/
Gemfile.lock
gemfiles/**.lock
.idea/
.ruby-version
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## master

- [PR#165](https://github.com/DmitryTsepelev/rubocop-graphql/pull/165) Drop support for rubocop < 1.50 ([@fatkodima][])
- [PR#164](https://github.com/DmitryTsepelev/rubocop-graphql/pull/164) Fix FieldDefinitions autocorrection for fields with squished heredocs ([@fatkodima][])

## 1.5.2 (2024-06-01)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
source "https://rubygems.org"

gem "rubocop", "1.0"
gem "rubocop", "1.50"

gemspec path: "../"
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
source "https://rubygems.org"

gem "rubocop", "1.59"
gem "rubocop", "1.64"

gemspec path: "../"
3 changes: 1 addition & 2 deletions rubocop-graphql.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ Gem::Specification.new do |spec|

spec.add_development_dependency "bundler", "~> 2.0"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rspec", "~> 3.9"

spec.add_runtime_dependency "rubocop", ">= 0.90", "< 2"
spec.add_runtime_dependency "rubocop", ">= 1.50", "< 2"
end
2 changes: 0 additions & 2 deletions spec/rubocop/cop/graphql/unused_argument_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,6 @@ def resolve(arg1:, arg2:, user:, cards:, article:, notes:); end
end

context "when args is forwarding arguments" do
let(:ruby_version) { 2.7 } # forward arguments was introduced in Ruby 2.7

it "does not registers an offense" do
expect_no_offenses(<<~RUBY)
class SomeResolver < Resolvers::Base
Expand Down

0 comments on commit 8dcdeb8

Please sign in to comment.