ExtractInputType: show all excess args in offense (#32)

DmitryTsepelev · Apr 8, 2021 · 2c1a3e0 · 2c1a3e0
1 parent 22590d6
commit 2c1a3e0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/rubocop/cop/graphql/extract_input_type.rb b/lib/rubocop/cop/graphql/extract_input_type.rb
@@ -32,7 +32,12 @@ def on_class(node)
           if (body = schema_member.body)
             arguments = body.select { |node| argument?(node) }
 
-            add_offense(arguments.last) if arguments.count > cop_config["MaxArguments"]
+            excess_arguments = arguments.count - cop_config["MaxArguments"]
+            return unless excess_arguments.positive?
+
+            arguments.last(excess_arguments).each do |excess_argument|
+              add_offense(excess_argument)
+            end
           end
         end
       end

diff --git a/spec/rubocop/cop/graphql/extract_input_type_spec.rb b/spec/rubocop/cop/graphql/extract_input_type_spec.rb
@@ -34,12 +34,13 @@ class UpdateUser < BaseMutation
   end
 
   context "when count of fields is more than Max fields" do
-    it "registers an offense" do
+    it "registers an offense for each line over Max fields" do
       expect_offense(<<~RUBY)
         class UpdateUser < BaseMutation
           argument :uuid, ID, required: true
           argument :first_name, String, required: true
           argument :last_name, String, required: true
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Consider moving arguments to a new input type
           argument :email, String, required: true
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Consider moving arguments to a new input type
         end