Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composeDirective directive, fixes #72 #91

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

cschiewek
Copy link
Contributor

Pretty straight forward addition of the composeDirective directive.

I also considered adding a compose macro to notation to facilitate expansion, so that the link and composeDirective would be automatically added to the schema without having to add them to the extend schema block:

directive :custom do
  compose "https://spec.example.org/custom/v1.0"
  on [:schema]
end

I decided against it for this PR, but if that is something y'all think is worth the effort, let me know and I'll create an issue and do it at some point.

Cheers!

@kzlsakal
Copy link
Collaborator

kzlsakal commented Feb 9, 2024

@cschiewek thank you for the PR!

I also considered adding a compose macro to notation to facilitate expansion, so that the link and composeDirective would be automatically added to the schema without having to add them to the extend schema block

This is a very nice idea, although it's fine to support @composeDirective without that convenience for now.

cschiewek and others added 2 commits February 12, 2024 08:11
@cschiewek cschiewek requested a review from kzlsakal February 12, 2024 13:16
@kzlsakal kzlsakal merged commit 57e281e into DivvyPayHQ:main Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants