Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link directive should be repeatable #89

Merged
merged 3 commits into from
Feb 6, 2024
Merged

The link directive should be repeatable #89

merged 3 commits into from
Feb 6, 2024

Conversation

cschiewek
Copy link
Contributor

@cschiewek
Copy link
Contributor Author

Would love to see a 0.4.1 release if/when this is merged.

Copy link
Collaborator

@kzlsakal kzlsakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cschiewek! Would you be able to add a test that verifies the repeatable behaviour?

@cschiewek
Copy link
Contributor Author

@kzlsakal Would Absinthe.Federation.NotationTest be the appropriate module for that test? I don't see any other test that explicitly checking any of the federation directives.

@cschiewek cschiewek requested a review from kzlsakal February 6, 2024 19:09
@cschiewek cschiewek requested a review from kzlsakal February 6, 2024 19:40
Copy link
Collaborator

@kzlsakal kzlsakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @cschiewek!

@kzlsakal kzlsakal merged commit d900316 into DivvyPayHQ:main Feb 6, 2024
3 checks passed
@kzlsakal kzlsakal added the enhancement New feature or request label Feb 6, 2024
@cschiewek
Copy link
Contributor Author

Thank you for the quick release @kzlsakal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants