Relax dataloader dependency versions to allow version 2 and above #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzlsakal
approved these changes
Jan 30, 2024
|
@chloe-meister we had to revert this since Dataloader version 2 and above is only supported by absinthe version 1.7.5 and above. We need to update the absinthe dependency in mix.exs as well to allow that version as well for this to work. We should probably loosen absinthe to |
|
Yes, I thought about this but wasn't sure if it was an issue or not. Thanks for letting me know! Would you like me to propose something for the update to Absinthe 1.7? Sadly I'd probably need to comment out the Notation tests until the issue in the Absinthe repo is resolved, as it breaks the |
|
I believe there is another MR that would include this change. It would be nice if you'd like to collaborate on it :) |
|
Yes, for sure :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Dataloader with version >= 2.0 in a project makes it impossible to also use
absinthe_federation.As mentioned in the issue it looks fine to relax the version constraint.